3489: workload report period average + etc #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeppekroghitk
changed the base branch from
develop
to
feature/2597-add-epic-relations
tuj
requested changes
Jan 2, 2025
| @@ -114,23 +115,74 @@ public function findWorklogsByWorkerAndDateRange(string $workerIdentifier, \Date | |||
|
|
|||
| public function findBillableWorklogsByWorkerAndDateRange(string $workerIdentifier, \DateTime $dateFrom, \DateTime $dateTo) | |||
| { | |||
| $nonBillableEpics = NonBillableEpicsEnum::getAsArray(); | |||
There was a problem hiding this comment.
These changes cannot work before issue.epics is a field and a migration has been added.
Add this to the Epics PR instead.
There was a problem hiding this comment.
I think that these changes belong here, as they are connected to the workload report and utilize the additions made in #183 . This PR is based off it as well.
| @@ -5,6 +5,7 @@ | |||
| use App\Entity\Account; | |||
| use App\Entity\Client; | |||
| use App\Entity\DataProvider; | |||
| use App\Entity\Epic; | |||
jeppekroghitk
force-pushed
the
feature/3489-workload-report-period-average-etc
branch
3 times, most recently
from
377b748 to
f0f0e4e
Compare
tuj
approved these changes
Jan 8, 2025
jeppekroghitk
force-pushed
the
feature/3489-workload-report-period-average-etc
branch
from
f0f0e4e to
99cf7ae
Compare
jeppekroghitk
force-pushed
the
feature/2597-add-epic-relations
branch
from
b33d2b3 to
099623a
Compare
…port repository methods
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
…y-report Invoicing rate report
jeppekroghitk
merged commit ccb5044
into
feature/2597-add-epic-relations
9 checks passed
jeppekroghitk
deleted the
feature/3489-workload-report-period-average-etc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
3489
Description
The PR introduces some general changes to the workload report, as well as averages for each period.
Changes include:
Screenshot of the result
N/A
Checklist